Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #90296: go-to-protobuf: fix rewrite of embedded struct fields #91731

Merged
merged 3 commits into from
Jul 8, 2020
Merged

Automated cherry pick of #90296: go-to-protobuf: fix rewrite of embedded struct fields #91731

merged 3 commits into from
Jul 8, 2020

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Jun 3, 2020 •
edited

Cherry pick of #90296 on release-1.17.

#90296: go-to-protobuf: fix rewrite of embedded struct fields

For details on the cherry pick process, see the cherry pick requests page.

Release note:

NONE

@mandelsoft
go-to-protobuf: fix rewrite of embedded struct fields
2636dfa 
The protobuf generator cannot handle embedded struct fields correctly.
When using an embedded field by pointer it produces the error message

`unable to get name for tag from struct "...", field ...`

The reason is that the name determination evaluating the AST does not
handle pointers if the AST does not already contain a field name.
This seems to be the case for structs embedded by pointers.

Example:

```
type MyStruct struct {
  *OtherStruct `protobuf:"bytes,1,opt,name=otherStruct"`
}
```
@mandelsoft
some tests for new function
742f303
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Jun 3, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 3, 2020
@k8s-ci-robot
Copy link
Contributor

@mandelsoft: This cherry pick PR is for a release branch and has not yet been approved by the Patch Release Team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, please ping the kubernetes/patch-release-team in a comment, after it has been approved by the relevant OWNERS.
For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @mandelsoft. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2020
@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 3, 2020
@mandelsoft
Copy link
Contributor Author

/assign @smarterclayton

@mandelsoft
Copy link
Contributor Author

/assign @lavalamp

@tpepper
Copy link
Member

tpepper commented Jun 9, 2020

/kind bug
/priority important-soon
from parent PR

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 9, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 9, 2020
@lavalamp
Copy link
Member

lavalamp commented Jun 9, 2020

same q as other cherry-pick, do we really need to backport this?

@mandelsoft
Copy link
Contributor Author

@lavalamp see my comment in the other PR (#91825)

@lavalamp
Copy link
Member

ACK, ok, that seems like a good reason to go back this far.

/ok-to-test
/approve

/hold for getting the binary file which I missed in the original PR out, sorry

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2020
@mandelsoft mandelsoft force-pushed the automated-cherry-pick-of-#90296-upstream-release-1.17 branch from 573cd90 to ad71bca Compare June 23, 2020 09:35
@mandelsoft
Copy link
Contributor Author

/retest

@mandelsoft
Copy link
Contributor Author

Binary has been removed, sorry for that.

@mandelsoft
Copy link
Contributor Author

/retest

@timuthy
Copy link
Contributor

timuthy commented Jul 7, 2020

@lavalamp may I ask you to take another look? Would really appreciate if you approve this PR since we depend on it.

@lavalamp
Copy link
Member

lavalamp commented Jul 7, 2020

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, mandelsoft

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit eeb3718 into kubernetes:release-1.17 Jul 8, 2020
@timuthy timuthy mentioned this pull request Jul 8, 2020
Merged
@ialidzhikov ialidzhikov mentioned this pull request Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@lavalamp lavalamp

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mandelsoft @k8s-ci-robot @tpepper @lavalamp @timuthy @feiskyer @smarterclayton